[PATCH] D29736: [WebAssembly] Add target specific overrides for lgamma family functions

2017-02-09 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google added a comment. https://clang.llvm.org/compatibility.html doesn't mention anything about POSIX, only C11 compliance, so I didn't think Clang in general cared about POSIX. That being said I can definitely agree that Clang shouldn't preclude POSIX. I'll open a more-general diff.

[PATCH] D29736: [WebAssembly] Add target specific overrides for lgamma family functions

2017-02-08 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. It doesn't make sense to do this in WebAssembly-specific code; every POSIX platform has a signgam which behaves the same way. https://reviews.llvm.org/D29736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29736: [WebAssembly] Add target specific overrides for lgamma family functions

2017-02-08 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google created this revision. Herald added a subscriber: jfb. Current WebAssembly implementations use musl libc, which writes to signgam in its lgamma functions. We want the rest of the builtins to be const under -fno-math-errno, so overwrite lgamma's builtin definitions to be