faisalv closed this revision.
faisalv added a comment.
Closed by commit https://reviews.llvm.org/rL295279
https://reviews.llvm.org/D29748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/AST/ExprConstant.cpp:428-429
+llvm::DenseMap LambdaCaptureFields;
+FieldDecl *LambdaThisCaptureField;
+
I'm a little concerned
hubert.reinterpretcast added inline comments.
Comment at: lib/AST/ExprConstant.cpp:5061
+ APValue RVal;
+ // FIXME: We need to make sure we're passing the right type that
+ // maintains cv-qualifiers.
faisalv wrote:
> rsmith wrote:
> >
faisalv added inline comments.
Comment at: lib/AST/ExprConstant.cpp:5061
+ APValue RVal;
+ // FIXME: We need to make sure we're passing the right type that
+ // maintains cv-qualifiers.
rsmith wrote:
> faisalv wrote:
> > I don't think
faisalv updated this revision to Diff 87943.
faisalv marked 6 inline comments as done.
faisalv added a comment.
Incorporated Richard's feedback and added comments.
https://reviews.llvm.org/D29748
Files:
lib/AST/ExprConstant.cpp
test/SemaCXX/cxx1z-constexpr-lambdas.cpp
Index:
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:5061
+ APValue RVal;
+ // FIXME: We need to make sure we're passing the right type that
+ // maintains cv-qualifiers.
faisalv wrote:
> I don't think we need this fixme
faisalv added inline comments.
Comment at: lib/AST/ExprConstant.cpp:5061
+ APValue RVal;
+ // FIXME: We need to make sure we're passing the right type that
+ // maintains cv-qualifiers.
I don't think we need this fixme - the type of
faisalv created this revision.
faisalv added a project: clang-c.
Herald added a subscriber: EricWF.
This patch attempts to enable evaluation of all forms of captures (however
deeply nested) within constexpr lambdas.
Appreciate the feedback.
Thanks!
Repository:
rL LLVM
