rmaprath added a comment.
Hi @EricWF
Apologies for the delay in replying to this.
In https://reviews.llvm.org/D29818#711795, @EricWF wrote:
> I really dislike that `__libcpp_clock_monotonic` and
> `__libcpp_clock_realtime` are never declared, and are expected to be
> magically defined by the
EricWF added a comment.
I really dislike that `__libcpp_clock_monotonic` and `__libcpp_clock_realtime`
are never declared, and are expected to be magically defined by the external
threading header.
This makes the configuration seem incorrect and unused.
Also the previous threading support
jroelofs added a comment.
In https://reviews.llvm.org/D29818#700949, @ed wrote:
> Worth mentioning: the latest version of macOS now supports `clock_gettime()`.
> Maybe better to leave the code as is and simply axe the Mach time code at
> some point in the future?
Supporting only the latest
ed added a comment.
Worth mentioning: the latest version of macOS now supports `clock_gettime()`.
Maybe better to leave the code as is and simply axe the Mach time code at some
point in the future?
https://reviews.llvm.org/D29818
___
cfe-commits
rmaprath added a comment.
@EricWF: Ping?
https://reviews.llvm.org/D29818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 90025.
rmaprath added a comment.
Fixed minor omission.
https://reviews.llvm.org/D29818
Files:
src/chrono.cpp
Index: src/chrono.cpp
===
--- src/chrono.cpp
+++ src/chrono.cpp
@@ -11,6 +11,7
rmaprath updated this revision to Diff 89665.
rmaprath added a comment.
Different approach: Externalize these functions only for the
external-thread-api library variant.
(Similar to https://reviews.llvm.org/D29757)
https://reviews.llvm.org/D29818
Files:
src/chrono.cpp
Index:
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I really don't like this change (and https://reviews.llvm.org/D29757) because
they start to include a ton of extra headers, and because they lift complex
configuration logic into
rmaprath added a comment.
Ping?
https://reviews.llvm.org/D29818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 88190.
rmaprath added a comment.
Re-based.
https://reviews.llvm.org/D29818
Files:
include/__threading_support
src/chrono.cpp
Index: src/chrono.cpp
===
--- src/chrono.cpp
+++
rmaprath created this revision.
These implementations depend heavily on the underlying platform. It would be
good to put them behind a porting function within the threading API as quite a
bit of threading functionality depend on the clocks.
The `steady_clock::now()` implementation was
11 matches
Mail list logo