This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL295048: [clang-tidy] Improve diagnostic message for
misc-definitions-in-header. (authored by hokein).
Changed prior to commit:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
https://reviews.llvm.org/D29928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:131-135
+if (FD->getTemplateSpecializationKind() != TSK_Undeclared)
+ diag(FD->getLocation(), "this is a full function template specilization
hokein updated this revision to Diff 88336.
hokein added a comment.
Address review comment.
https://reviews.llvm.org/D29928
Files:
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
test/clang-tidy/misc-definitions-in-headers.hpp
Index: test/clang-tidy/misc-definitions-in-headers.hpp
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:131-135
+if (FD->getTemplateSpecializationKind() != TSK_Undeclared)
+
hokein created this revision.
Herald added a subscriber: JDevlieghere.
Users might get confused easily when they see the check's message on
full template function speciliations.
Add a note to the output message, which mentions these kind of function
specializations are treated as regular
