This revision was automatically updated to reflect the committed changes.
Closed by commit rL296062: [profiling] PR31992: Don't skip interesting non-base
constructors (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D30131?vs=89151=89595#toc
Repository:
rL LLVM
vsk added a comment.
In https://reviews.llvm.org/D30131#684310, @arphaman wrote:
> LGTM.
>
> One point to note, when we are displaying coverage for constructors that have
> both the base and complete versions instrumented, e.g.:
>
> class Foo {
> public:
> Foo() { }
> };
>
>
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM.
One point to note, when we are displaying coverage for constructors that have
both the base and complete versions instrumented, e.g.:
class Foo {
public:
Foo() { }
};
vsk updated this revision to Diff 89151.
vsk retitled this revision from "[profiling] Don't skip non-base constructors
if there is a virtual base (fixes PR31992)" to "[profiling] PR31992: Don't skip
interesting non-base constructors".
vsk edited the summary of this revision.
vsk added a comment.
