dcoughlin added a comment.
Looks great. Thanks!!
https://reviews.llvm.org/D30373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ddcc reopened this revision.
ddcc added a comment.
This revision is now accepted and ready to land.
Made a mistake with the last commit, I believe this should be fine now?
Repository:
rL LLVM
https://reviews.llvm.org/D30373
___
cfe-commits
ddcc reopened this revision.
ddcc added a comment.
This revision is now accepted and ready to land.
You're right about the failure being specific to Windows, I'll roll back to the
original implementation in `lit.local.cfg` and just skip on Windows.
Repository:
rL LLVM
dcoughlin added a comment.
Thanks for sticking with this!!
This looks good to me, although I would prefer if the definition of the
AnalyzerTest class were moved to the bottom of the lit.cfg file. The other
configuration and substitutions are far more important to the rest of clang --
people
dcoughlin added a comment.
In https://reviews.llvm.org/D30373#689613, @ddcc wrote:
> With the first method, I'm not sure how to refer to the `AnalyzerTest` class
> defined in `lit.cfg` from `lit.local.cfg`. It doesn't seem to be in scope, so
> unless I store an instantiation in the `config`
ddcc added a comment.
With the first method, I'm not sure how to refer to the `AnalyzerTest` class
defined in `lit.cfg` from `lit.local.cfg`. It doesn't seem to be in scope, so
unless I store an instantiation in the `config` object, I don't think it's
accessible.
Repository:
rL LLVM
dcoughlin added a comment.
I'm not sure what is going on.
One thing to try is defining the class in clang/test/lit.cfg -- which seems to
work for Swift. (See
https://github.com/apple/swift/blob/master/test/lit.cfg#L137) We'd still want
to only use that class in Analysis/lit.local.cfg.
dcoughlin added a comment.
Saving the relevant portion of the build bot log output before it disappears
from the bot:
0.000 [0/1/0] Running all regression tests
-- Testing: 31894 tests, 80 threads --
Traceback (most recent call last):
File "", line 1, in
File
ddcc reopened this revision.
ddcc added a comment.
This revision is now accepted and ready to land.
It looks like there's some sort of pickling-related test failure when lit tries
to fork, because it can't find the class `lit.TestingConfig.AnalyzerTest`:
ddcc reopened this revision.
ddcc added a comment.
This revision is now accepted and ready to land.
Looks like there were four latent test failures that had been masked due to the
way they were written. Here's the new version.
Repository:
rL LLVM
https://reviews.llvm.org/D30373
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D30373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
11 matches
Mail list logo
