This revision was automatically updated to reflect the committed changes.
Closed by commit rL296549: [Test] Make Lit tests C++11 compatible - IR ordering
(authored by lcharles).
Changed prior to commit:
https://reviews.llvm.org/D30430?vs=90078=90101#toc
Repository:
rL LLVM
tigerleapgorge added a comment.
In https://reviews.llvm.org/D30430#688146, @rjmccall wrote:
> The C++98 behavior here is not really vital to test precisely; it's just
> minor differences in what gets instantiated and when.
Hi John, my main concern with CHECK-NOT appearing between CHECK lines
tigerleapgorge updated this revision to Diff 90078.
tigerleapgorge added a comment.
Updated patch.
Test only runs in C++11.
Added comments to explain CHECK-DAG and CHECK2-NOT.
https://reviews.llvm.org/D30430
Files:
test/CodeGenCXX/template-instantiation.cpp
Index:
rjmccall added a comment.
The C++98 behavior here is not really vital to test precisely; it's just minor
differences in what gets instantiated and when. I think it's fine to just
update the run line to -std=c++11 for things like this. But if you really want
to test both configurations, this
tigerleapgorge created this revision.
This test failure is caused by difference in IR ordering when compiling at
C++98 vs C++11
Because there was a CHECK-NOT between the two CHECKs, just changing the CHECKs
to CHECK-DAG would not work.
So to make FileCheck more flexible.
I have changed the
