[PATCH] D30459: [libcxxabi] Clean up macro usage

2017-03-01 Thread Ranjeet Singh via Phabricator via cfe-commits
rs added a comment. ok thanks. https://reviews.llvm.org/D30459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30459: [libcxxabi] Clean up macro usage

2017-03-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL296612: [libcxxabi] Clean up macro usage. (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D30459?vs=90150=90155#toc Repository: rL LLVM https://reviews.llvm.org/D30459

[PATCH] D30459: [libcxxabi] Clean up macro usage

2017-03-01 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath added a comment. In https://reviews.llvm.org/D30459#689461, @rs wrote: > Thanks for reviewing. Before I commit could you tell me if I need to update > any build systems e.g. buildbots ? Those two options are not used by any of the current public builders, so I think it's safe to

[PATCH] D30459: [libcxxabi] Clean up macro usage

2017-02-28 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. I renamed `LIBCXXABI_ARM_EHABI` to `_LIBCXXABI_ARM_EHABI` so you'll have to merge this change with that. Other than that this LGTM. https://reviews.llvm.org/D30459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30459: [libcxxabi] Clean up macro usage

2017-02-28 Thread Ranjeet Singh via Phabricator via cfe-commits
rs created this revision. Herald added a subscriber: mgorny. Convention in libcxxabi is to use !defined(FOO) not !FOO. https://reviews.llvm.org/D30459 Files: CMakeLists.txt include/__cxxabi_config.h include/cxxabi.h src/abort_message.cpp src/config.h src/cxa_default_handlers.cpp