This revision was automatically updated to reflect the committed changes.
Closed by commit rL297194: Use filename in linemarker when compiling
preprocessed source (Revised) (authored by twoh).
Changed prior to commit:
https://reviews.llvm.org/D30663?vs=90735=90912#toc
Repository:
rL LLVM
inglorion accepted this revision.
inglorion added a comment.
This revision is now accepted and ready to land.
Fixing the other issues in a follow-up seems fine. This lgtm.
https://reviews.llvm.org/D30663
___
cfe-commits mailing list
twoh updated this revision to Diff 90735.
twoh added a comment.
Herald added a subscriber: mehdi_amini.
addressing comments from @inglorion
https://reviews.llvm.org/D30663
Files:
include/clang/Frontend/FrontendOptions.h
lib/Frontend/FrontendAction.cpp
test/Frontend/preprocessed-input.i
twoh added inline comments.
Comment at: test/Frontend/preprocessed-input.c:3
+// RUN: %clang -emit-llvm -S -o - %t.i | FileCheck %s
+// CHECK: source_filename = {{.*}}preprocessed-input.c"{{$}}
inglorion wrote:
> Actually, I think you don't even have to run the
inglorion added inline comments.
Comment at: test/Frontend/preprocessed-input.c:3
+// RUN: %clang -emit-llvm -S -o - %t.i | FileCheck %s
+// CHECK: source_filename = {{.*}}preprocessed-input.c"{{$}}
Actually, I think you don't even have to run the preprocessor -
twoh created this revision.
This is a revised version of https://reviews.llvm.org/D28796. Included test is
changed to
resolve the target compatibility issue reported
(https://reviews.llvm.org/rL293032).
https://reviews.llvm.org/D30663
Files:
include/clang/Frontend/FrontendOptions.h
