This revision was automatically updated to reflect the committed changes.
Closed by commit rL297790: Canonicalize the path provided by
-fmodules-cache-path. (authored by adrian).
Changed prior to commit:
https://reviews.llvm.org/D30915?vs=91628=91791#toc
Repository:
rL LLVM
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Frontend/CompilerInvocation.cpp:1434
+
+ // Canonicalize -fmodules-cache-path before storing it.
+ SmallString<128>
aprantl created this revision.
This fixes lookup mismatches that could previously happen when the module cache
path contained a '/./' component.
In combination with https://reviews.llvm.org/D28299 this bug can cause a
use-after-free.
rdar://problem/30413458
https://reviews.llvm.org/D30915
