[PATCH] D30990: Add more examples to clang-format configuration

2017-03-20 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru updated this revision to Diff 92316. sylvestre.ledru marked an inline comment as done. https://reviews.llvm.org/D30990 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h

[PATCH] D30990: Add more examples to clang-format configuration

2017-03-20 Thread Daniel Jasper via Phabricator via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good, just minor remarks. Comment at: include/clang/Format/Format.h:974 + ///# With: + ///MacroBlockBegin: "^\ + ///NS_MAP_BEGIN|\

[PATCH] D30990: Add more examples to clang-format configuration

2017-03-20 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. Daniel, is that ok with you? https://reviews.llvm.org/D30990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30990: Add more examples to clang-format configuration

2017-03-15 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru updated this revision to Diff 91928. sylvestre.ledru added a comment. Improve consistency on an example https://reviews.llvm.org/D30990 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h

[PATCH] D30990: Add more examples to clang-format configuration

2017-03-15 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru updated this revision to Diff 91925. sylvestre.ledru added a comment. More example (JS) https://reviews.llvm.org/D30990 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h

[PATCH] D30990: Add more examples to clang-format configuration

2017-03-15 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:671 + + bool value = a ++ a Is this example valid? I don't see

[PATCH] D30990: Add more examples to clang-format configuration

2017-03-15 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D30990 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h === ---