rjmccall added a comment.
In https://reviews.llvm.org/D31003#711359, @bkelley wrote:
> Thank you @rjmccall for the approval. I don't have commit access; would
> someone be willing to commit this path for me please? Thanks!
You have a lot of patches here. :) I would encourage you to just ask
bkelley added a comment.
Thank you @rjmccall for the approval. I don't have commit access; would someone
be willing to commit this path for me please? Thanks!
https://reviews.llvm.org/D31003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall added a comment.
Thanks, LGTM.
https://reviews.llvm.org/D31003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkelley marked 2 inline comments as done.
bkelley added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4407
+ (SemaRef.getLangOpts().ObjCWeak &&
+FieldBaseElementType.getObjCLifetime() == Qualifiers::OCL_Weak))) {
+// ARC and Weak:
bkelley updated this revision to Diff 92216.
bkelley marked an inline comment as done.
bkelley added a comment.
Integrated feedback from @rjmccall
https://reviews.llvm.org/D31003
Files:
lib/AST/DeclCXX.cpp
lib/Sema/SemaDeclCXX.cpp
test/CodeGenObjCXX/objc-weak.mm
Index:
rjmccall added inline comments.
Comment at: lib/AST/DeclCXX.cpp:727
+ !(Context.getLangOpts().ObjCWeak &&
+T.getObjCLifetime() == Qualifiers::OCL_Weak)) {
setHasObjectMember(true);
Similarly, I think the best way of expressing this
bkelley created this revision.
When adding an Objective-C retainable type member to a C++ class, also check
the LangOpts.ObjCWeak flag and the lifetime qualifier so __weak qualified
Objective-C pointer members cause the class to be a non-POD type with
non-trivial special members, so the
