[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

bkelley added a comment. Thank you @rjmccall for the approval. I don't have commit access; would someone be willing to commit this path for me please? Thanks! https://reviews.llvm.org/D31007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D31007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

bkelley added inline comments. Comment at: lib/Sema/SemaInit.cpp:6681 // full-expression's cleanups. - if ((S.getLangOpts().ObjCAutoRefCount && - MTE->getType()->isObjCLifetimeType()) || + if (MTE->getType()->isNonTrivialObjCLifetimeType() ||

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

bkelley updated this revision to Diff 92966. bkelley marked an inline comment as done. bkelley added a comment. Updated with latest feedback from @rjmccall https://reviews.llvm.org/D31007 Files: lib/Sema/SemaCast.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaInit.cpp

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:6681 // full-expression's cleanups. - if ((S.getLangOpts().ObjCAutoRefCount && - MTE->getType()->isObjCLifetimeType()) || + if (MTE->getType()->isNonTrivialObjCLifetimeType() ||

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

bkelley added inline comments. Comment at: lib/AST/Type.cpp:3773 +/// lifetime semantics. +bool Type::isNonTrivialObjCLifetimeType() const { + return CanonicalType.hasNonTrivialObjCLifetime(); rjmccall wrote: > Is this method not identical in behavior to

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

bkelley updated this revision to Diff 92892. https://reviews.llvm.org/D31007 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/Sema/SemaCast.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaInit.cpp test/SemaObjCXX/objc-weak.mm Index: test/SemaObjCXX/objc-weak.mm

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

rjmccall added inline comments. Comment at: lib/AST/Type.cpp:3773 +/// lifetime semantics. +bool Type::isNonTrivialObjCLifetimeType() const { + return CanonicalType.hasNonTrivialObjCLifetime(); Is this method not identical in behavior to

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

bkelley updated this revision to Diff 92220. bkelley added a comment. Integrated feedback from @rjmccall https://reviews.llvm.org/D31007 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/Sema/SemaCast.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaInit.cpp

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

bkelley added a comment. Thanks for all the feedback! I think things are looking a lot better now. https://reviews.llvm.org/D31007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

rjmccall added a comment. Same thing about parts of this patch — please try to just check T.hasNonTrivialObjCLifetime() when reasonable. Thank you for all this, by the way. :) https://reviews.llvm.org/D31007 ___ cfe-commits mailing list

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

bkelley created this revision. After examining the remaining uses of LangOptions.ObjCAutoRefCount, found a some additional places to also check for ObjCWeak not covered by previous test cases. Added a test file to verify all the code paths that were changed. https://reviews.llvm.org/D31007