[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki abandoned this revision. danielmarjamaki added a comment. I believe https://reviews.llvm.org/D32164 is better Repository: rL LLVM https://reviews.llvm.org/D31097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. > Or I can do it for you if you wish. yes please Repository: rL LLVM https://reviews.llvm.org/D31097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

baloghadamsoftware added a comment. Or I can do it for you if you wish. Repository: rL LLVM https://reviews.llvm.org/D31097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

baloghadamsoftware added a comment. OK, please create a patch where implicit casts are disabled by default. You can also find a new name for the checker. Repository: rL LLVM https://reviews.llvm.org/D31097 ___ cfe-commits mailing list

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. I would recommend that this is either fixed soon or that we commit my changes so it can be implemented more properly later. Right now users will see false positives. Repository: rL LLVM https://reviews.llvm.org/D31097

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. Well.. feel free to provide an alternative fix. If the message is more specific and it must be enabled explicitly by an option then maybe it's good enough for me. Repository: rL LLVM https://reviews.llvm.org/D31097

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. In https://reviews.llvm.org/D31097#707385, @baloghadamsoftware wrote: > Hi! > > There is an option to disable the checking of widening casts. It is enabled > by default. You can disable it any time. Or, if you find too much false > positives, we can discuss

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

baloghadamsoftware added a comment. Hi! There is an option to disable the checking of widening casts. It is enabled by default. You can disable it any time. Or, if you find too much false positives, we can discuss about setting this option to disabled as default. I am convinced that checking

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. I believe there is pointless code in relativeIntSizes etc. If there is for instance "a+b" then the result can't be a char type. static int relativeIntSizes(BuiltinType::Kind Kind) { switch (Kind) { case BuiltinType::UChar: return 1; case

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki updated this revision to Diff 92322. danielmarjamaki added a comment. Remove warnings for implicit casts. Repository: rL LLVM https://reviews.llvm.org/D31097 Files: clang-tidy/misc/MisplacedWideningCastCheck.cpp clang-tidy/misc/MisplacedWideningCastCheck.h

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. In https://reviews.llvm.org/D31097#704628, @alexfh wrote: > In https://reviews.llvm.org/D31097#704626, @alexfh wrote: > > > In https://reviews.llvm.org/D31097#704621, @xazax.hun wrote: > > > > > I wonder whether warning on implicit casts still makes sense for

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

alexfh added a comment. In https://reviews.llvm.org/D31097#704626, @alexfh wrote: > In https://reviews.llvm.org/D31097#704621, @xazax.hun wrote: > > > I wonder whether warning on implicit casts still makes sense for example in > > mission critical code. So maybe it is worth to have a

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

xazax.hun added a comment. In https://reviews.llvm.org/D31097#704626, @alexfh wrote: > In https://reviews.llvm.org/D31097#704621, @xazax.hun wrote: > > > I wonder whether warning on implicit casts still makes sense for example in > > mission critical code. So maybe it is worth to have a

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

alexfh added a comment. In https://reviews.llvm.org/D31097#704621, @xazax.hun wrote: > I wonder whether warning on implicit casts still makes sense for example in > mission critical code. So maybe it is worth to have a configuration option > with the default setting being less strict and

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

xazax.hun added a comment. I wonder whether warning on implicit casts still makes sense for example in mission critical code. So maybe it is worth to have a configuration option with the default setting being less strict and chatty. What do you think? Repository: rL LLVM

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. In my opinion, we should stop warning about all implicit casts. Take for instance: long l1; if (condition) l1 = n << 8; // <- implicit cast else l1 = ~0L; That is fine. Nothing suspicious. Just because the destination variable is long doesn't

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki created this revision. Herald added a subscriber: JDevlieghere. This patch fixes https://bugs.llvm.org/show_bug.cgi?id=32246 To avoid spurious warnings, clang-tidy should not warn about misplaced widening casts for implicit casts in function calls. Repository: rL LLVM