Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D31183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
echuraev updated this revision to Diff 93132.
echuraev marked an inline comment as done.
https://reviews.llvm.org/D31183
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/Parser/vector-cast-define.cl
Index: test/Parser/vector-cast-define.cl
Anastasia added a comment.
I don't think that diagnostics can always be very clear. This is not the case
neither for C nor C++.
As I said I don't see any issue to continue with this patch. I would just like
to see the test simplified a bit.
https://reviews.llvm.org/D31183
echuraev added a comment.
In https://reviews.llvm.org/D31183#710202, @Anastasia wrote:
> In https://reviews.llvm.org/D31183#709566, @echuraev wrote:
>
> > In https://reviews.llvm.org/D31183#708833, @yaxunl wrote:
> >
> > > I think this is a good feature for the convenience of user. I've seen
>
Anastasia added a comment.
In https://reviews.llvm.org/D31183#709566, @echuraev wrote:
> In https://reviews.llvm.org/D31183#708833, @yaxunl wrote:
>
> > I think this is a good feature for the convenience of user. I've seen usage
> > like this.
>
>
> I agree. I don't see any reasons why this
echuraev added a comment.
In https://reviews.llvm.org/D31183#708833, @yaxunl wrote:
> I think this is a good feature for the convenience of user. I've seen usage
> like this.
I agree. I don't see any reasons why this case doesn't have the right to exist.
I don't think that using extra
yaxunl added a comment.
I think this is a good feature for the convenience of user. I've seen usage
like this.
https://reviews.llvm.org/D31183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Anastasia added a comment.
Although nothing wrong with the implementation apart from it complicates a bit
the understanding of conventional C parse flow by adding extra corner case, I
don't see anything in the spec that states explicitly how the vector components
should be parsed. I guess with
echuraev created this revision.
Herald added a subscriber: yaxunl.
https://reviews.llvm.org/D31183
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/Parser/vector-cast-define.cl
Index: test/Parser/vector-cast-define.cl