[PATCH] D31334: [clang-format] Add options for indenting preprocessor directives

2017-09-07 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius abandoned this revision. curdeius added a comment. Superseded by https://reviews.llvm.org/rL312125. https://reviews.llvm.org/D31334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31334: [clang-format] Add options for indenting preprocessor directives

2017-03-28 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Thanks Daniel. I'll give it a try using the proposed approach and update you soon(ish). https://reviews.llvm.org/D31334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31334: [clang-format] Add options for indenting preprocessor directives

2017-03-27 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added a comment. Thank you for working on this. Unfortunately, this is done at the wrong level: - You are using a separate pass, which means that as soon as the preprocessor directives exceed the column limit, they won't be wrapped correctly. - You aren't using Clang's Lexer to separate