[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr abandoned this revision. huntergr added a comment. In D31417#1450587 , @xtian wrote: > LGTM. This provides a consistent behavior same as GCC and ICC w/ > -fopenmp-simd option. To answer, Kelvin's question. it is not directly tied > with

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

xtian accepted this revision. xtian added a comment. This revision is now accepted and ready to land. Herald added subscribers: jdoerfert, jfb, guansong. LGTM. This provides a consistent behavior same as GCC and ICC w/ -fopenmp-simd option. To answer, Kelvin's question. it is not directly tied

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

ABataev added a comment. I think we can abandon this one as support for -fopenmp-simd was committed already? https://reviews.llvm.org/D31417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

hfinkel added a comment. In https://reviews.llvm.org/D31417#886826, @huntergr wrote: > In https://reviews.llvm.org/D31417#886441, @hfinkel wrote: > > > Is this still being worked on? > > > Hi, yes it is. Sorry for the delay in posting new changes but priorities > shifted a bit and I had to work

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added a comment. In https://reviews.llvm.org/D31417#886441, @hfinkel wrote: > Is this still being worked on? Hi, yes it is. Sorry for the delay in posting new changes but priorities shifted a bit and I had to work on something else for a while. I do have a new version that's just

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

hfinkel added a comment. Is this still being worked on? https://reviews.llvm.org/D31417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

ABataev added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:174 + case OMPD_target_teams_distribute_simd: +DKind = OMPD_simd; +break; huntergr wrote: > ABataev wrote: > > huntergr wrote: > > > rengolin wrote: > > > > I'd like

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:174 + case OMPD_target_teams_distribute_simd: +DKind = OMPD_simd; +break; ABataev wrote: > huntergr wrote: > > rengolin wrote: > > > I'd like @ABataev to confirm this is

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

kkwli0 added inline comments. Comment at: docs/ClangCommandLineReference.rst:1454 +.. option:: -fopenmp-simd, -fno-openmp-simd + I am not sure if it is target architecture specific or not. If it is, should we be under the target flag instead?

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

ABataev added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:122-123 createOpenCLRuntime(); - if (LangOpts.OpenMP) + if (LangOpts.OpenMP || LangOpts.OpenMPSimd) createOpenMPRuntime(); if (LangOpts.CUDA) I don't think you need to create

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:174 + case OMPD_target_teams_distribute_simd: +DKind = OMPD_simd; +break; rengolin wrote: > I'd like @ABataev to confirm this is the right semantics. Yes, would be good. I

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

rengolin added a comment. Hi Graham, It looks much simpler now, thanks! I'm ok with the change, but I'd like @ABataev to confirm that the semantics is the expected one for all cases and approve. cheers, --renato Comment at: lib/Parse/ParseOpenMP.cpp:174 + case

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr updated this revision to Diff 93841. huntergr added a reviewer: kkwli0. huntergr added a comment. Changed to transform combined constructs to simd in ParseOpenMP.cpp instead of creating a new pragma handler. This also made it easier to add support for 'declare simd': only needed the

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

rengolin added a comment. In https://reviews.llvm.org/D31417#713171, @huntergr wrote: > The other alternative I thought of was to perform the filtering in > ParseOpenMP.cpp instead, but I need to figure out how to delete or skip > tokens there without cluttering up the rest of the OpenMP

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added a comment. Hi Renato, In https://reviews.llvm.org/D31417#713162, @rengolin wrote: > I don't know much about Clang's machinery, but would it be possible to have > `-fopenmp-simd` generate the same handler, but with restrictions? I fear this > slight duplication could get

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

rengolin added a comment. Hi Graham, I don't know much about Clang's machinery, but would it be possible to have `-fopenmp-simd` generate the same handler, but with restrictions? I fear this slight duplication could get considerably worse as we support more and more "non-RT" OMP pragmas.

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added a comment. In https://reviews.llvm.org/D31417#712008, @fpetrogalli wrote: > Hi Graham, > > thank you for working on this. I understand that you are gonna take care of > the CodeGen side of things for the new `-fopenmp-simd` option in a separate > patch? CodeGen for 'simd'

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

fpetrogalli added a comment. Hi Graham, thank you for working on this. I understand that you are gonna take care of the CodeGen side of things for the new `-fopenmp-simd` option in a separate patch? I am asking because I expect that the tests in `test/OpenMP/declare_simd_*` will give the same

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr created this revision. Herald added a subscriber: rengolin. Adds a new flag ('-fopenmp-simd') to clang which enables processing of 'simd' and 'declare simd' pragmas without supporting the rest of OpenMP. The pragma handler will filter out directives and clauses which aren't related to