salari01 abandoned this revision.
salari01 added a comment.
In https://reviews.llvm.org/D31496#721262, @rnk wrote:
> `-Wl,--defsym` is also a pretty common linker option. I'm hesitant to add
> this to the driver interface, since it seems like they could easily be
> confused.
I see. Was not aw
sanwou01 added reviewers: rnk, rsmith.
sanwou01 added a comment.
Hi Salman,
This essentially looks good to me. I don't think I'm the right person to LGTM
this however, so I've added some reviewers who might be able to have a look.
Thanks,
Sanne
https://reviews.llvm.org/D31496
_
rogfer01 added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:1882
+TakeNextArg = true;
}
} else {
salari01 wrote:
> rogfer01 wrote:
> > I wonder if you should `break;` here if validation fails like the original
> > co
salari01 added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:1882
+TakeNextArg = true;
}
} else {
rogfer01 wrote:
> I wonder if you should `break;` here if validation fails like the original
> code did?
The reason for
rogfer01 added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:1882
+TakeNextArg = true;
}
} else {
I wonder if you should `break;` here if validation fails like the original code
did?
https://reviews.llvm.org/D31496
salari01 created this revision.
Extended the integrated assembler -Wa,-defsym option to be usable with the
Clang driver. Both options arehandled in the same way. Using -defsym when
not assembling files shows an unused argument warning.
https://reviews.llvm.org/D31496
Files:
include/clan
