[PATCH] D31887: [clangd] Add documentation page

2017-05-03 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! Thank you! https://reviews.llvm.org/D31887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31887: [clangd] Add documentation page

2017-04-28 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle-ericsson added a comment. In https://reviews.llvm.org/D31887#740747, @Prazek wrote: > In https://reviews.llvm.org/D31887#740727, @malaperle-ericsson wrote: > > > Would it be possible to commit this? I do not have commit rights. Thanks! > > > Why won't you get commit right? You will

[PATCH] D31887: [clangd] Add documentation page

2017-04-28 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a comment. In https://reviews.llvm.org/D31887#740727, @malaperle-ericsson wrote: > Would it be possible to commit this? I do not have commit rights. Thanks! Why won't you get commit right? You will probably make some other contribution to clangd, so it will be handy to have it :)

[PATCH] D31887: [clangd] Add documentation page

2017-04-28 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle-ericsson added a comment. Would it be possible to commit this? I do not have commit rights. Thanks! https://reviews.llvm.org/D31887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31887: [clangd] Add documentation page

2017-04-27 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. Looks good, nothing to add from my side. https://reviews.llvm.org/D31887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31887: [clangd] Add documentation page

2017-04-27 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle-ericsson added a comment. Ping. Any more objections? https://reviews.llvm.org/D31887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31887: [clangd] Add documentation page

2017-04-16 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle-ericsson updated this revision to Diff 95416. malaperle-ericsson removed a subscriber: Sarcasm. malaperle-ericsson added a comment. Update with comments (extra backticks, etc) https://reviews.llvm.org/D31887 Files: docs/clangd.rst docs/index.rst Index: docs/index.rst

[PATCH] D31887: [clangd] Add documentation page

2017-04-15 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. Great to see this coming along! Comment at: docs/clangd.rst:10 + +:program:`clangd` is an implementation of the `Language Server Protocol `_ leveraging Clang. +Clangd's goal is to provide

[PATCH] D31887: [clangd] Add documentation page

2017-04-12 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle-ericsson updated this revision to Diff 95078. malaperle-ericsson added a comment. Fix mention of "extra Clang tools" https://reviews.llvm.org/D31887 Files: docs/clangd.rst docs/index.rst Index: docs/index.rst ===

[PATCH] D31887: [clangd] Add documentation page

2017-04-12 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre added inline comments. Comment at: docs/clangd.rst:28 + +You can follow the instructions for `building Clang `_ but "extra Clang Tool" is **not** optional. + In the reference, it is called "extra Clang tools".

[PATCH] D31887: [clangd] Add documentation page

2017-04-11 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle-ericsson added a comment. Sorry about all the typos. I have now installed a spell checked in VS Code :) https://reviews.llvm.org/D31887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31887: [clangd] Add documentation page

2017-04-11 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle-ericsson updated this revision to Diff 94815. malaperle-ericsson marked 6 inline comments as done. malaperle-ericsson added a comment. Fixed typos and other comments. https://reviews.llvm.org/D31887 Files: docs/clangd.rst docs/index.rst Index: docs/index.rst

[PATCH] D31887: [clangd] Add documentation page

2017-04-11 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: docs/clangd.rst:16 + +Clangd is not meant to be used by C/C++ developpers directly but rather from a client implementing the protocol. +A client would be typically implemented in an IDE or an editor. kromanenkov

[PATCH] D31887: [clangd] Add documentation page

2017-04-11 Thread Kirill Romanenkov via Phabricator via cfe-commits
kromanenkov added inline comments. Comment at: docs/clangd.rst:10 + +:program:`clangd` is an implementation of the `Languge Server Protocol `_ leveraging Clang. +Clangd's goal is to provide language "smartness" features

[PATCH] D31887: [clangd] Add documentation page

2017-04-11 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. Maybe this is a good time to decide ClangD, Clangd, or clangd is the correct capitalization. Repository: rL LLVM https://reviews.llvm.org/D31887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org