[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

joerg added a comment. Actually, for NetBSD we want to use -fomit-frame-pointer by default whenever the implicit -funwind-tables is also present. In general, that should be the justification for the default behavior: "Can I reliably unwind a binary with the available information?" Performance

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib updated this revision to Diff 101675. chrib added a comment. - do not omit the frame pointer for netbsd-eabi and darwin-eabi https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/frame-pointer.c Index: test/Driver/frame-pointer.c

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib added a comment. OK, I have created a RFE tracker (BZ #32501). I will forward to cfe-dev. Regarding the need to avoid table-based unwinding, the way to handle those request for an explicit frame pointer when not required by the ABI is to use -fno-omit-frame-pointer flag, catching up with

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

efriedma added a comment. Please start a thread on cfe-dev about this; most developers don't read cfe-commits, and thinking about it a bit more, I'm not confident omitting frame pointers is really a good default. I would guess there's existing code which depends on frame pointers to come up

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { efriedma wrote: > chrib wrote: > > efriedma wrote: > > > Specifically checking for

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib updated this revision to Diff 101543. chrib added a comment. Herald added a subscriber: kristof.beyls. - Merge branch 'master' of ssh://codex.cro.st.com/llvm-arm/clang - Don't need a frame pointer for EABIHF also (AAPCS) https://reviews.llvm.org/D31972 Files:

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

efriedma added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { chrib wrote: > efriedma wrote: > > Specifically checking for "llvm::Triple::EABI" is

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { efriedma wrote: > Specifically checking for "llvm::Triple::EABI" is suspicious... what are you

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

efriedma added reviewers: t.p.northover, efriedma. efriedma added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { Specifically checking for

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib added inline comments. Comment at: test/CodeGen/arm-fp-eabi.c:1 +// RUN: %clang %s -target arm-none-eabi -O2 -S -o nofp.s +// RUN: not grep '.setfp' nofp.s ahatanak wrote: > Instead of generating a .s file and looking for ".setfp", you can pass -### > and

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib updated this revision to Diff 96109. chrib added a comment. - Check not mdisable-fp-elim for arm eabi when optimizing https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/frame-pointer.c Index: test/Driver/frame-pointer.c

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

ahatanak added inline comments. Comment at: test/CodeGen/arm-fp-eabi.c:1 +// RUN: %clang %s -target arm-none-eabi -O2 -S -o nofp.s +// RUN: not grep '.setfp' nofp.s Instead of generating a .s file and looking for ".setfp", you can pass -### and check the

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib updated this revision to Diff 95958. chrib added a comment. - Fix thinko in test https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang.cpp test/CodeGen/arm-fp-eabi.c Index: test/CodeGen/arm-fp-eabi.c ===

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib updated this revision to Diff 95945. chrib added a comment. 1. Updating https://reviews.llvm.org/D31972: Do not force the frame pointer by default for ARM EABI # Add test case https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang.cpp test/CodeGen/arm-fp-eabi.c

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

ahatanak added a comment. Can you add a test case? https://reviews.llvm.org/D31972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib created this revision. Herald added a subscriber: aemerson. Do not force the frame pointer by default for ARM EABI (bugzilla #32501) https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang.cpp Index: lib/Driver/ToolChains/Clang.cpp