This revision was automatically updated to reflect the committed changes.
Closed by commit rL305394: PR32476: __nop_locale_mgmt.h not needed with newlib
2.5+ (authored by jyknight).
Changed prior to commit:
https://reviews.llvm.org/D32146?vs=102265=102562#toc
Repository:
rL LLVM
waltl added a comment.
In https://reviews.llvm.org/D32146#780231, @bcraig wrote:
> LGTM.
> @waltl : Do you need me to submit the changes, or will you handle that?
Thanks -- I think jyknight will handle it.
https://reviews.llvm.org/D32146
___
bcraig accepted this revision.
bcraig added a comment.
LGTM.
@waltl : Do you need me to submit the changes, or will you handle that?
https://reviews.llvm.org/D32146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MartinO accepted this revision.
MartinO added a comment.
This revision is now accepted and ready to land.
`Looks good. Previously I had also got a check for 'defined(__NEWLIB_MINOR__)'
but I realise that was not necessary`
https://reviews.llvm.org/D32146
mclow.lists added a comment.
This change looks fine to me - but I don't have the different newlib versions
to test against.
Once everyone else is happy with the version detection, then I'm good with this.
https://reviews.llvm.org/D32146
___
waltl updated this revision to Diff 102265.
waltl added a comment.
PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+
Newlib 2.5 added the locale management functions, so it should not
include __nop_local_mgmt.h. This change adds proper guard around that
include statement.
For newlib
waltl commandeered this revision.
waltl added a reviewer: bcraig.
waltl added a comment.
Thanks for submitting the patch -- I will make the necessary revision and test
it.
https://reviews.llvm.org/D32146
___
cfe-commits mailing list
MartinO added a comment.
The introduction of the macros '__NEWLIB__' and '__NEWLIB_MINOR__' appear to
have been first introduced in Newlib v2.3.0.20160226, but the new interface for
'' was introduced in Newlib v2.4.0.20160923 - previous releases of
v2.4.0 did not make these changes.
This is
bcraig added inline comments.
Comment at: include/support/newlib/xlocale.h:20
+#if defined(__NEWLIB__) && (__NEWLIB__ == 2) \
+&& defined(__NEWLIB_MINOR__) && (__NEWLIB_MINOR__ >= 5) \
+&& (!defined(__POSIX_VISIBLE) || (__POSIX_VISIBLE < 200809))
orivej
orivej added inline comments.
Comment at: include/support/newlib/xlocale.h:20
+#if defined(__NEWLIB__) && (__NEWLIB__ == 2) \
+&& defined(__NEWLIB_MINOR__) && (__NEWLIB_MINOR__ >= 5) \
+&& (!defined(__POSIX_VISIBLE) || (__POSIX_VISIBLE < 200809))
You
bcraig created this revision.
newlib 2.5 added the locale management functions, and so our stub
__nop_locale_mgmt.h shouldn't be included, as it conflicts with newlibs
definitions. newlib 2.4 and earlier still need the header though.
Patch by Martin J. O'Riordan
11 matches
Mail list logo
