This revision was automatically updated to reflect the committed changes.
Closed by commit rL300722: [Sema][ObjC] Disallow jumping into ObjC fast
enumeration loops. (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D32187?vs=95667&id=95781#toc
Repository:
rL LLVM
htt
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, this looks great. A few tweaks about the diagnostic and LGTM.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4985
+def note_protected_by_objc_fast_enumer
ahatanak updated this revision to Diff 95667.
ahatanak added a comment.
Unconditionally ban jumping into body of ObjC fast enumeration loop.
https://reviews.llvm.org/D32187
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/JumpDiagnostics.cpp
lib/Sema/SemaStmt.cpp
test/SemaObjC
rjmccall added a comment.
I wouldn't mind unconditionally banning this in JumpDiagnostics, actually.
https://reviews.llvm.org/D32187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak created this revision.
This fixes a bug in EmitObjCForCollectionStmt which is causing clang to
generate malformed IR.
When the following code (which I think is legal, at least when it is not
compiled with ARC) is compiled:
$ cat test1.m
@interface Obj
@end
void bar(void);
voi
