malaperle-ericsson added a comment.
Thanks a lot!
Repository:
rL LLVM
https://reviews.llvm.org/D32234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300990: [Clangd] Support Authority-less URIs (authored by
d0k).
Changed prior to commit:
https://reviews.llvm.org/D32234?vs=95809=96152#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32234
bkramer added a comment.
Still looking good. Will commit this soon.
https://reviews.llvm.org/D32234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson added a comment.
Benjamin, I added a test, do you still think it's OK? Thanks!
https://reviews.llvm.org/D32234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson updated this revision to Diff 95809.
malaperle-ericsson added a comment.
Add test
https://reviews.llvm.org/D32234
Files:
clangd/Protocol.cpp
test/clangd/completion.test
Index: test/clangd/completion.test
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This is fine. Test case would be nice though.
Repository:
rL LLVM
https://reviews.llvm.org/D32234
___
cfe-commits mailing list
