This revision was automatically updated to reflect the committed changes.
Closed by commit rL300985: [clang-format] Replace IncompleteFormat by a struct
with Line (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D32298?vs=96131=96141#toc
Repository:
rL LLVM
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Sounds good.
https://reviews.llvm.org/D32298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krasimir added inline comments.
Comment at: include/clang/Format/Format.h:1524
+ /// best-effort analysis, and could be imprecise.
+ unsigned Line = 0;
+};
krasimir wrote:
> djasper wrote:
> > Hm. Something we might need to be thinking about here is whether
krasimir added inline comments.
Comment at: include/clang/Format/Format.h:1524
+ /// best-effort analysis, and could be imprecise.
+ unsigned Line = 0;
+};
djasper wrote:
> Hm. Something we might need to be thinking about here is whether this should
> be the
krasimir updated this revision to Diff 96131.
krasimir added a comment.
- Refactor tests
https://reviews.llvm.org/D32298
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
lib/Format/UnwrappedLineFormatter.h
test/Format/incomplete.cpp
krasimir updated this revision to Diff 96129.
krasimir marked 5 inline comments as done.
krasimir added a comment.
- Changed IncompleteFormat to FormatComplete
https://reviews.llvm.org/D32298
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
djasper added inline comments.
Comment at: include/clang/Format/Format.h:1519
+ /// formatted due to a non-recoverable syntax error.
+ bool IncompleteFormat = false;
+
Maybe we should invert this and make this FormatComplete or something?
Otherwise this is
