emilio added a comment.
> FWIW when I wrote https://reviews.llvm.org/D26663, I did it because arguments
> weren't inspectionable at all for `using` declarations. Actually both of them
> would've worked for me.
Also, this bit was not completely accurate, and you could inspect ones, but not
othe
emilio added a comment.
Revert + tests @ https://reviews.llvm.org/D32566
Repository:
rL LLVM
https://reviews.llvm.org/D32348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
emilio added a comment.
In https://reviews.llvm.org/D32348#738704, @rsmith wrote:
> This change looks like it introduces a regression itself: given
>
> template struct A {};
> template using B = A;
> B bi;
>
>
> ... requesting the template arguments for the type `B` changes from
> producin
rsmith added a comment.
This change looks like it introduces a regression itself: given
template struct A {};
template using B = A;
B bi;
... requesting the template arguments for the type `B` changes from
producing `int` to producing `int*` with this patch, which seems to directly
oppo
arphaman added a comment.
@emilio, you can request to merge this into 4.0.1 by using a script called
merge-request.sh
(http://lists.llvm.org/pipermail/llvm-dev/2017-March/111530.html).
Repository:
rL LLVM
https://reviews.llvm.org/D32348
___
cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301328: [libclang] Check for a record declaration before a
template specialization (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D32348?vs=96130&id=96590#toc
Repository:
r
arphaman added a comment.
Sure. You can ask Chris Lattner for commit access for future patches :)
https://reviews.llvm.org/D32348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
emilio added a comment.
Yes, please! I've submitted a few patches, but still no commit access.
Thanks!
https://reviews.llvm.org/D32348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
I see, thanks for explaining. LGTM. Do you need someone to commit it?
https://reviews.llvm.org/D32348
___
cfe-commits mailing list
cfe-commit
emilio added inline comments.
Comment at: clang/test/Index/print-type.cpp:118
// CHECK: TemplateRef=Foo:4:8 [type=] [typekind=Invalid] [isPOD=0]
-// CHECK: FieldDecl=qux:29:38 (Definition) [type=Qux,
outer::inner::Bar::FooType>] [typekind=Unexposed] [templateargs/4= [type=int]
arphaman added inline comments.
Comment at: clang/test/Index/print-type.cpp:118
// CHECK: TemplateRef=Foo:4:8 [type=] [typekind=Invalid] [isPOD=0]
-// CHECK: FieldDecl=qux:29:38 (Definition) [type=Qux,
outer::inner::Bar::FooType>] [typekind=Unexposed] [templateargs/4= [type=int
emilio updated this revision to Diff 96130.
emilio added a comment.
Full diff, thanks @arphaman :)
https://reviews.llvm.org/D32348
Files:
clang/test/Index/print-type.cpp
clang/tools/libclang/CXType.cpp
Index: clang/tools/libclang/CXType.cpp
arphaman added a comment.
Please post the diff with full context (git diff -U).
Repository:
rL LLVM
https://reviews.llvm.org/D32348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
emilio created this revision.
emilio added a project: clang-c.
This allows us to see the default template parameters too.
This is a regression in clang 4.0, so uplifting to a dot release would be neat
(but not required, I guess).
The regression was caused by https://reviews.llvm.org/D26663.
Fi
14 matches
Mail list logo
