This revision was automatically updated to reflect the committed changes.
Closed by commit rL303635: [Tooling][libclang] Remove unused
CompilationDatabase::MappedSources (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D32351?vs=96138&id=99905#toc
Repository:
rL LLVM
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
krasimir added a comment.
@klimek: ping
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added a comment.
@klimek: ping
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added a comment.
@klimek: We don't have any clients of this field inside clang.
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Is there a specific reason to take this out? It seems generally useful to allow
compilation-db implementors to provide sources.
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
bkramer added a comment.
lg from my side. It would be good to wait until Manuel is back though, I think
he had plans for extending this interface at some point.
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krasimir created this revision.
Herald added a subscriber: klimek.
This field is never assigned to and it's only ever read from libclang.
This patch removes it and adapts libclang to return constants.
https://reviews.llvm.org/D32351
Files:
include/clang/Tooling/CompilationDatabase.h
tools/l
