This revision was automatically updated to reflect the committed changes.
Closed by commit rL307830: [Driver] Update Fuchsia driver path handling
(authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D32613?vs=106275=106276#toc
Repository:
rL LLVM
phosek updated this revision to Diff 106275.
Repository:
rL LLVM
https://reviews.llvm.org/D32613
Files:
lib/Driver/ToolChains/Fuchsia.cpp
lib/Driver/ToolChains/Fuchsia.h
test/Driver/fuchsia.cpp
Index: test/Driver/fuchsia.cpp
phosek updated this revision to Diff 102271.
Repository:
rL LLVM
https://reviews.llvm.org/D32613
Files:
lib/Driver/ToolChains/Fuchsia.cpp
lib/Driver/ToolChains/Fuchsia.h
test/Driver/fuchsia.cpp
Index: test/Driver/fuchsia.cpp
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D32613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
phosek updated this revision to Diff 97665.
phosek added a comment.
Done
Repository:
rL LLVM
https://reviews.llvm.org/D32613
Files:
lib/Driver/ToolChains/Fuchsia.cpp
lib/Driver/ToolChains/Fuchsia.h
test/Driver/fuchsia.cpp
Index: test/Driver/fuchsia.cpp
mcgrathr added a comment.
Perhaps use llvm::sys::path::parent_path instead of explicit "..".
Perhaps put the getDriver.Dir() + .. + getTriple().str() logic into a shared
subroutine.
Use default rather that CST_Libstdcxx in the switches on GetCXXStdlibType.
Repository:
rL LLVM
phosek created this revision.
Several improvements to the Fuchsia driver:
- Search for C++ library headers and libraries in directories that are part of
the toolchain distribution rather than sysroot.
- Use LLVM support utlities to construct paths to make sure the driver is also
usable
