kuhar updated this revision to Diff 99103.
kuhar added a comment.
The patch broke the spinx docs build and I had to revert it in r303140.
I fixed the docs file problems.
Repository:
rL LLVM
https://reviews.llvm.org/D32690
Files:
clang-tidy/modernize/UseEmplaceCheck.cpp
clang-tidy/moderni
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303139: [clang-tidy] modernize-use-emplace: Remove
unnecessary make_tuple calls (authored by kuhar).
Changed prior to commit:
https://reviews.llvm.org/D32690?vs=98073&id=99100#toc
Repository:
rL LLVM
Prazek accepted this revision.
Prazek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
JDevlieghere added a comment.
No comments from me either, looks good!
https://reviews.llvm.org/D32690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kuhar updated this revision to Diff 98073.
kuhar added a comment.
Herald added a subscriber: xazax.hun.
I updated the patch against the current trunk.
I also run the modernize-use-emplace check on llvm and verified that there are
no new regressions after applying fixits.
https://reviews.llvm.o
JonasToth added a comment.
i like the generalization.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
unless(isInTemplateInstantiation()))
.bind("call"),
this);
i t
kuhar updated this revision to Diff 97299.
kuhar edited the summary of this revision.
kuhar added a comment.
I went ahead and generalized the patch to support custom tuple-like types and
custom make_ functions.
I added a bunch of tests and updated the docs.
Let me know what you think.
https://
kuhar added a comment.
In https://reviews.llvm.org/D32690#741952, @JonasToth wrote:
> Would it make sense to add boost pairs/tuples support?
I think it can be added the same way it is possible to specify smart pointers
and vector-like containers now. It would require users to provide both type
JonasToth added a comment.
Nothing to complain from my side.
Would it make sense to add boost pairs/tuples support?
I could imagine modernize checks that would transform boost structures into
the stl ones, but that's another discussion probably.
Something for a later check: the same logic shoul
kuhar updated this revision to Diff 97248.
kuhar added a comment.
Cosmetic changes.
https://reviews.llvm.org/D32690
Files:
clang-tidy/modernize/UseEmplaceCheck.cpp
docs/ReleaseNotes.rst
test/clang-tidy/modernize-use-emplace.cpp
Index: test/clang-tidy/modernize-use-emplace.cpp
===
kuhar created this revision.
kuhar added a project: clang-tools-extra.
This patch makes modernize-use-emplace remove unnecessary make_tuple calls from
push_back calls and turn them into emplace_back -- the same way make_pair calls
are handled.
Eq.
std::vector> v;
v.push_back(std::make_tupl
11 matches
Mail list logo
