This revision was automatically updated to reflect the committed changes.
Closed by commit rL302016: [analyzer] Fix memory error bug category
capitalization. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D32702?vs=97574=97609#toc
Repository:
rL LLVM
xazax.hun accepted this revision.
xazax.hun added a comment.
Even better :)
https://reviews.llvm.org/D32702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin accepted this revision.
a.sidorin added a comment.
Thank you!
https://reviews.llvm.org/D32702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ updated this revision to Diff 97574.
NoQ added a comment.
Added a reusable bug category.
https://reviews.llvm.org/D32702
Files:
include/clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
zaks.anna accepted this revision.
zaks.anna added a comment.
Thanks!
https://reviews.llvm.org/D32702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added a comment.
Hi Artem. It is a good point but I think we should have a literal for this
instead.
https://reviews.llvm.org/D32702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D32702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ created this revision.
It seems that we're not capitalizing every word in our bug type descriptions,
however `Memory Error` is an exception from this rule. Additionally, one of the
nullability checkers actually does spell it as `Memory error`. So i guess it's
better to keep everything
