[PATCH] D33023: clang-format: [JS] wrap params with trailing commas.

This revision was automatically updated to reflect the committed changes. Closed by commit rL303049: JavaScript allows parameter lists to include trailing commas: (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D33023?vs=98971&id=98979#toc Repository: rL LLVM https:

[PATCH] D33023: clang-format: [JS] wrap params with trailing commas.

mprobst updated this revision to Diff 98971. mprobst marked an inline comment as done. mprobst added a comment. fix formatting a bit https://reviews.llvm.org/D33023 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp unittests/Format/

[PATCH] D33023: clang-format: [JS] wrap params with trailing commas.

mprobst marked an inline comment as done. mprobst added inline comments. Comment at: unittests/Format/FormatTest.cpp:5505 + verifyFormat( + "void aa(\n" + "int level,\n" djasper wrote: > Don't add this line break? I suspect your cla

[PATCH] D33023: clang-format: [JS] wrap params with trailing commas.

mprobst updated this revision to Diff 98969. mprobst marked 2 inline comments as done. mprobst added a comment. - only trigger wrapping in js mode, revert appropriate tests https://reviews.llvm.org/D33023 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp unittests/F

[PATCH] D33023: clang-format: [JS] wrap params with trailing commas.

djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1043 +bool EndsInComma = +Current.MatchingParen && Please make this specific to JavaScript for now. C++ doesn't allow trailing commas here and a trailing comma is more l