nik abandoned this revision.
nik added a comment.
I do not have time to work on this right now, Abandoning.
https://reviews.llvm.org/D33045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nik updated this revision to Diff 99740.
https://reviews.llvm.org/D33045
Files:
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
tools/libclang/CIndexCodeCompletion.cpp
Index: tools/libclang/CIndexCodeCompletion.cpp
nik added a comment.
In https://reviews.llvm.org/D33045#759436, @ilya-biryukov wrote:
> Are there any other callers to getMainBufferWithPrecompiledPreamble?
Yes. Huch, right... don't know why I didn't adapted those. Done now.
> Maybe they cause LibclangReparseTest.ReparseWithModule to fail?
ilya-biryukov added a comment.
Sorry, didn't get a chance to look into it very thoroughly yet.
Are there any other callers to getMainBufferWithPrecompiledPreamble?
Maybe they cause LibclangReparseTest.ReparseWithModule to fail?
Comment at: lib/Frontend/ASTUnit.cpp:1395
+
nik added a comment.
Ping :)
https://reviews.llvm.org/D33045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Hmm, looks like libclang/libclangTests/LibclangReparseTest.ReparseWithModule is
flaky?
FAIL: Clang-Unit ::
libclang/libclangTests/LibclangReparseTest.ReparseWithModule (10699 of 10701)
- TEST 'Clang-Unit ::
libclang/libclangTests/LibclangReparseTest.ReparseWithModule'
