This revision was automatically updated to reflect the committed changes.
Closed by commit rL303466: [test] Add support for Objective-C++ tests (authored
by epilk).
Changed prior to commit:
https://reviews.llvm.org/D33049?vs=99633=99643#toc
Repository:
rL LLVM
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
erik.pilkington updated this revision to Diff 99633.
erik.pilkington marked an inline comment as done.
erik.pilkington added a comment.
This new patch checks to make sure ARC is enabled in the tests, thanks for the
suggestion!
https://reviews.llvm.org/D33049
Files:
jroelofs added a comment.
Would be good to test for the presence/absence of the flag, too:
Comment at: test/libcxx/selftest/test.arc.pass.mm:10
+//===--===//
+
+int main()
```
#if
erik.pilkington updated this revision to Diff 99628.
erik.pilkington added a comment.
In this new patch:
- Add support for toggling -fobjc-arc, this is done by using file extensions,
ie: `foo.arc.pass.mm` instead of `foo.pass.mm`. (Thanks @dexonsmith for the
suggestion!)
- Clean up/simplify
dexonsmith added inline comments.
Comment at: utils/libcxx/compiler.py:110-114
+if input_is_text:
+if is_objcxx:
+cmd += ['-x', 'objective-c++', '-fobjc-arc']
+else:
+cmd += ['-x', 'c++']
Do we
erik.pilkington created this revision.
This patch adds lit testing support for Objective-C++. I'm going to be working
on improving Objective-C++ support in libc++ this summer, and it would be nice
to write tests. I tested this patch on Ubuntu 16.04 with gcc 5.4, and it works
fine (the .mm
