This revision was automatically updated to reflect the committed changes.
Closed by commit rL303173: [clangd] Refactor ProtocolHandlers to decouple them
from ClangdLSPServer (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D33201?vs=99129&id=99145#toc
Repository:
rL
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good!
Comment at: clangd/ClangdLSPServer.h:33
+ /// each instance of ClangdLSPServer.
+ void run(std::istream &In);
ilya-biryukov wrote:
> kras
ilya-biryukov updated this revision to Diff 99129.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
Addressed review comments
https://reviews.llvm.org/D33201
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdMain.cpp
clangd/ClangdServe
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:20
+template
+std::string replacementsToEdits(StringRef Code, const T &Replacements) {
+ // Turn the replacements into the format specified by the Language Server
krasimir wrote:
> Hm,
krasimir added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:20
+template
+std::string replacementsToEdits(StringRef Code, const T &Replacements) {
+ // Turn the replacements into the format specified by the Language Server
Hm, this is a bit too gener
krasimir added a comment.
nit: rename this patch title to start with [clangd]
https://reviews.llvm.org/D33201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:206
-std::vector ClangdLSPServer::codeComplete(PathRef File,
- Position Pos) {
- return Server.codeComplete(File, Pos);
+ // Set up JSONRPCDispatche
ilya-biryukov updated this revision to Diff 99009.
ilya-biryukov added a comment.
Fixed a typo in a comment
https://reviews.llvm.org/D33201
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdMain.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/JSONRPCDi
