This revision was automatically updated to reflect the committed changes.
Closed by commit rL303541: [clang-format] Keep trailing preprocessor line
comments separate from the… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D33394?vs=99731=99734#toc
Repository:
rL
krasimir updated this revision to Diff 99731.
krasimir marked an inline comment as done.
krasimir added a comment.
- Remove parentheses
https://reviews.llvm.org/D33394
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestComments.cpp
Index:
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/UnwrappedLineParser.cpp:106
+ isLineComment(*Token) && Token->NewlinesBefore == 1 &&
+ Token->OriginalColumn ==
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:106
+ isLineComment(*Token) && Token->NewlinesBefore == 1 &&
+ Token->OriginalColumn == PreviousToken->OriginalColumn);
}
krasimir updated this revision to Diff 99729.
krasimir marked an inline comment as done.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D33394
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestComments.cpp
Index:
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:106
+ isLineComment(*Token) && Token->NewlinesBefore == 1 &&
+ Token->OriginalColumn == PreviousToken->OriginalColumn);
}
Any chance of moving this logic to
krasimir created this revision.
Herald added a subscriber: klimek.
r303415 changed the way a sequence of line comments following a preprocessor
macro is handled, which has the unfortunate effect of aligning a trailing
preprocessor line comment and following unrelated section comments, so:
