[PATCH] D33493: Speed up preamble loading

This revision was automatically updated to reflect the committed changes. Closed by commit rL305061: Speed up preamble loading (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D33493?vs=101995=102003#toc Repository: rL LLVM https://reviews.llvm.org/D33493 Files:

[PATCH] D33493: Speed up preamble loading

yvvan updated this revision to Diff 101995. yvvan added a comment. "what kind of performance benefits do you get for the preamble load times?" In cases where many windows headers are included preamble loading takes almost the half of reparse time. With this fix time to load preamble goes towards

[PATCH] D33493: Speed up preamble loading

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with one inline request below. I also have a question: what kind of performance benefits do you get for the preamble load times? Comment at:

[PATCH] D33493: Speed up preamble loading

yvvan updated this revision to Diff 101865. yvvan added a comment. Improve commentary. Use StringMap https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp

[PATCH] D33493: Speed up preamble loading

arphaman added inline comments. Comment at: lib/Frontend/ASTUnit.cpp:1152 + else +SrcLocCache.clear(); yvvan wrote: > arphaman wrote: > > Why is `clear` in an `else` here? We always create a new `SourceManager` in > > this function, so the previously

[PATCH] D33493: Speed up preamble loading

yvvan added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:192 + /// of that loading + std::map SrcLocCache; + arphaman wrote: > You can use an `llvm::StringMap` instead. I will change that Comment at:

[PATCH] D33493: Speed up preamble loading

arphaman added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:192 + /// of that loading + std::map SrcLocCache; + You can use an `llvm::StringMap` instead. Comment at: lib/Frontend/ASTUnit.cpp:1152 + else +

[PATCH] D33493: Speed up preamble loading

yvvan added a comment. In https://reviews.llvm.org/D33493#774264, @arphaman wrote: > Can you use a local map in `TranslateStoredDiagnostics` instead of storing > one in the `ASTUnit`, or do you need to keep it around? The whole purpose is to use it between different TranslateStoredDiagnostics

[PATCH] D33493: Speed up preamble loading

arphaman added a comment. Can you use a local map in `TranslateStoredDiagnostics` instead of storing one in the `ASTUnit`, or do you need to keep it around? https://reviews.llvm.org/D33493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan updated this revision to Diff 101533. yvvan added a comment. Remove global completion cache part because it's probably not always valid. https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan updated this revision to Diff 100605. yvvan added a comment. diff with -U https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp === ---