This revision was automatically updated to reflect the committed changes.
Closed by commit rL304515: Support lazy stat'ing of files referenced by module
maps. (authored by rsmith).
Changed prior to commit:
https://reviews.llvm.org/D33703?vs=101157=101162#toc
Repository:
rL LLVM
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D33703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith updated this revision to Diff 101157.
rsmith marked an inline comment as done.
rsmith added a comment.
Rebased and added requested test.
https://reviews.llvm.org/D33703
Files:
docs/Modules.rst
include/clang/Basic/DiagnosticLexKinds.td
rsmith added a comment.
In https://reviews.llvm.org/D33703#770896, @bruno wrote:
> - I've noticed in the patch that on the ASTWriter side we serialize the
> introduced size / mtime, but there are no changes to the ASTReader, so I
> assume in the reader side you still need the module map around
bruno added a comment.
Hi Richard,
Thanks for improving this further!
Questions / comments:
- I've noticed in the patch that on the ASTWriter side we serialize the
introduced size / mtime, but there are no changes to the ASTReader, so I assume
in the reader side you still need the module map
rsmith created this revision.
This patch adds support for a `header` declaration in a module map to specify
certain `stat` information (currently, size and mtime) about that header file.
This has two purposes:
- It removes the need to eagerly `stat` every file referenced by a module map.
