This revision was automatically updated to reflect the committed changes.
Closed by commit rL305075: [DebugInfo] Add kind of ImplicitParamDecl for
emission of FlagObjectPointer. (authored by ABataev).
Changed prior to commit:
https://reviews.llvm.org/D33735?vs=101908=102024#toc
Repository:
rjmccall accepted this revision.
rjmccall added inline comments.
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
aaron.ballman wrote:
> rjmccall wrote:
> > ABataev wrote:
> > > aaron.ballman wrote:
>
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from one minor nit, LGTM!
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
ABataev updated this revision to Diff 101908.
ABataev added a comment.
Removed FIXMEs and corrected comment
https://reviews.llvm.org/D33735
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/AST/Decl.cpp
lib/AST/DeclObjC.cpp
lib/CodeGen/CGBlocks.cpp
rjmccall added inline comments.
Comment at: include/clang/AST/Decl.h:1387
+IPK_CapturedContext, /// Parameter for captured context
+IPK_GeneralParam,/// General implicit parameter
+ };
ABataev wrote:
> rjmccall wrote:
> > I would just call this
ABataev updated this revision to Diff 101751.
ABataev added a comment.
Update after review
https://reviews.llvm.org/D33735
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/AST/Decl.cpp
lib/AST/DeclObjC.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGCXXABI.cpp
ABataev added inline comments.
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
aaron.ballman wrote:
> ABataev wrote:
> > aaron.ballman wrote:
> > > It's a bit strange to me that the non-parameter
aaron.ballman added inline comments.
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
ABataev wrote:
> aaron.ballman wrote:
> > It's a bit strange to me that the non-parameter declaration bits now
ABataev added inline comments.
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
aaron.ballman wrote:
> It's a bit strange to me that the non-parameter declaration bits now have a
> field for implicit
aaron.ballman added inline comments.
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
It's a bit strange to me that the non-parameter declaration bits now have a
field for implicit parameter
ABataev updated this revision to Diff 101571.
ABataev marked an inline comment as done.
ABataev added a comment.
Address John comments.
https://reviews.llvm.org/D33735
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/AST/Decl.cpp
lib/AST/DeclObjC.cpp
ABataev marked 7 inline comments as done.
ABataev added inline comments.
Comment at: include/clang/AST/Decl.h:1387
+IPK_CapturedContext, /// Parameter for captured context
+IPK_GeneralParam,/// General implicit parameter
+ };
rjmccall wrote:
> I
rjmccall added inline comments.
Comment at: include/clang/AST/Decl.h:1387
+IPK_CapturedContext, /// Parameter for captured context
+IPK_GeneralParam,/// General implicit parameter
+ };
I would just call this "Other" and document it as being for
ABataev updated this revision to Diff 101402.
ABataev added a comment.
Added DeclContext parameter to constructors of ImplicitParamDecl class.
https://reviews.llvm.org/D33735
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/AST/Decl.cpp
lib/AST/DeclObjC.cpp
ABataev updated this revision to Diff 101262.
ABataev added a comment.
Herald added a subscriber: jholewinski.
Added different kinds of ImplicitParamDecl.
https://reviews.llvm.org/D33735
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/AST/Decl.cpp
lib/AST/DeclObjC.cpp
rjmccall added inline comments.
Comment at: include/clang/AST/Decl.h:1388
SourceLocation IdLoc, IdentifierInfo *Id,
- QualType T);
+ QualType T, bool IsThisOrSelf = false);
ABataev updated this revision to Diff 101199.
ABataev added a comment.
Updates after review
https://reviews.llvm.org/D33735
Files:
include/clang/AST/Decl.h
lib/AST/Decl.cpp
lib/AST/DeclObjC.cpp
lib/CodeGen/CGCXXABI.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/Serialization/ASTReaderDecl.cpp
ABataev added a comment.
In https://reviews.llvm.org/D33735#770333, @rjmccall wrote:
> In https://reviews.llvm.org/D33735#770318, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D33735#770296, @ABataev wrote:
> >
> > > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote:
> >
rjmccall added a comment.
In https://reviews.llvm.org/D33735#770318, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33735#770296, @ABataev wrote:
>
> > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote:
> >
> > > Can you help me to understand what problem is being solved with
aaron.ballman added a comment.
In https://reviews.llvm.org/D33735#770296, @ABataev wrote:
> In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote:
>
> > Can you help me to understand what problem is being solved with this new
> > attribute? Under what circumstances would the first
ABataev added a comment.
In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote:
> Can you help me to understand what problem is being solved with this new
> attribute? Under what circumstances would the first argument be an
> `ImplicitParamDecl` but not an implicit this or self?
aaron.ballman added a comment.
Can you help me to understand what problem is being solved with this new
attribute? Under what circumstances would the first argument be an
`ImplicitParamDecl` but not an implicit this or self?
https://reviews.llvm.org/D33735
ABataev created this revision.
If the first parameter of the function is the ImplicitParamDecl codegen
automatically marks it as an implicit argument with `this` or `self`
pointer. To fix this problem Implicit ThisOrSelfAttr is added. This
attribute is used to mark real `this` or `self` pointers
23 matches
Mail list logo
