[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

2017-12-13 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added inline comments. Comment at: include/ostream:225 +basic_ostream& operator<<(nullptr_t) +{ return *this << (const void*)0; } + K-ballo wrote: > Quuxplusone wrote: > > mclow.lists wrote: > > > lichray wrote: > > > > Oh, common, I persuaded

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

2017-12-13 Thread Agustín Bergé via Phabricator via cfe-commits
K-ballo added inline comments. Comment at: include/ostream:225 +basic_ostream& operator<<(nullptr_t) +{ return *this << (const void*)0; } + Quuxplusone wrote: > mclow.lists wrote: > > lichray wrote: > > > Oh, common, I persuaded the committee to allow

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

2017-12-13 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: include/ostream:225 +basic_ostream& operator<<(nullptr_t) +{ return *this << (const void*)0; } + mclow.lists wrote: > lichray wrote: > > Oh, common, I persuaded the committee to allow you to print a `(null)`

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

2017-12-13 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. Other than the actual text being output, this LGTM. I'ld like to see the changes I suggested in the test go in, but they're really minor. Comment at: include/ostream:225 +basic_ostream& operator<<(nullptr_t) +{ return *this << (const

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

2017-12-12 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added inline comments. Comment at: include/ostream:225 +basic_ostream& operator<<(nullptr_t) +{ return *this << (const void*)0; } + Oh, common, I persuaded the committee to allow you to print a `(null)` and you don't do it...

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

2017-06-01 Thread Agustín Bergé via Phabricator via cfe-commits
K-ballo created this revision. With effects equivalent to `os << (const void*)nullptr`. https://reviews.llvm.org/D33776 Files: include/ostream test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/nullptr_t.pass.cpp www/cxx1z_status.html