This revision was automatically updated to reflect the committed changes.
Closed by commit rL305901: [clang-format] Support sorting using declarations
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D33823?vs=103032&id=103359#toc
Repository:
rL LLVM
https://reviews
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D33823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
krasimir added inline comments.
Comment at: lib/Format/UsingDeclarationsSorter.cpp:66
+ }
+ return HasIdentifier && Tok && Tok->isOneOf(tok::semi, tok::comma);
+}
Typz wrote:
> could also be followed by an assignment, in case of type alias:
>
> using foo = b
krasimir updated this revision to Diff 103032.
krasimir added a comment.
- Update test case
https://reviews.llvm.org/D33823
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/UsingDeclarationsSorter.cpp
lib/Format/UsingDeclarationsSorter.h
krasimir updated this revision to Diff 103031.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D33823
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/UsingDeclarations
klimek added inline comments.
Comment at: lib/Format/UsingDeclarationsSorter.cpp:41-42
+
+bool computeUsingDeclarationLabel(const FormatToken *UsingTok,
+ std::string *Label) {
+ assert(UsingTok && UsingTok->is(tok::kw_using) && "Expecting a usin
Typz added inline comments.
Comment at: lib/Format/UsingDeclarationsSorter.cpp:66
+ }
+ return HasIdentifier && Tok && Tok->isOneOf(tok::semi, tok::comma);
+}
could also be followed by an assignment, in case of type alias:
using foo = bar::foo;
https://rev
krasimir added a comment.
@klimek: ping
https://reviews.llvm.org/D33823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
