This revision was automatically updated to reflect the committed changes.
Closed by commit rL305544: [XRay][clang] Support capturing the implicit `this`
argument to C++ class… (authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D34052?vs=102491=102775#toc
Repository:
rL
On Mon, Jun 12, 2017 at 9:15 PM Dean Michael Berris via Phabricator <
revi...@reviews.llvm.org> wrote:
> dberris added a reviewer: dblaikie.
> dberris added a subscriber: dblaikie.
> dberris added a comment.
>
> @dblaikie -- do you have time to have a look?
>
Sure sure - no need to ping a patch
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks fine - thanks
https://reviews.llvm.org/D34052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dberris added a comment.
@dblaikie it turns out that this is a much simpler change now. PTAL?
https://reviews.llvm.org/D34052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dberris updated this revision to Diff 102491.
dberris added a comment.
- fixup: use bool arg in checkFunctionOrMethodParameterIndex
https://reviews.llvm.org/D34052
Files:
lib/Sema/SemaDeclAttr.cpp
test/Sema/xray-log-args-class.cpp
Index: test/Sema/xray-log-args-class.cpp
hard to say if it's more readable without seeing it - if you could attach a
patch, if it's easy enough/you worked it up before, might be worth
comparing/contrasting
On Tue, Jun 13, 2017 at 12:28 AM Dean Michael Berris via Phabricator <
revi...@reviews.llvm.org> wrote:
> dberris added a comment.
dberris added a comment.
In https://reviews.llvm.org/D34052#778670, @dblaikie wrote:
> I take it there's already handling for these attributes on non-member
> functions?
Yes, we're just extending it to also apply to the case where it doesn't support
this one case where we actually do need
dblaikie added a comment.
I take it there's already handling for these attributes on non-member functions?
There's probably a reason this code can't be wherever that code is & subtract
one from the index? (reducing code duplication by having all the error
handling, etc, in one place/once)
dberris updated this revision to Diff 102018.
dberris edited the summary of this revision.
dberris added a comment.
Adding related bug.
https://reviews.llvm.org/D34052
Files:
lib/Sema/SemaDeclAttr.cpp
test/Sema/xray-log-args-class.cpp
Index: test/Sema/xray-log-args-class.cpp
dberris created this revision.
Before this change, we couldn't capture the `this` pointer that's
implicitly the first argument of class member functions. There are some
interesting things we can do with capturing even just this single
argument for zero-argument member functions.
10 matches
Mail list logo