[PATCH] D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type

This revision was automatically updated to reflect the committed changes. Closed by commit rG21ff345d64b9: [Sema][C++1z] Ensure binding in dependent range for have non-null type (authored by erik.pilkington). Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang.

[PATCH] D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type

bebuch reopened this revision. bebuch added a comment. This revision is now accepted and ready to land. I believe this patch is incomplete, I get a very odd warning: struct A{ int x; }; template < typename > struct B{ A data_[1]; void f(){ for(auto [x]: d

[PATCH] D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type

This revision was automatically updated to reflect the committed changes. Closed by commit rL305195: [Sema][C++1z] Ensure binding in dependent range for have non-null type (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D34096?vs=102149&id=102191#toc Repository: rL LLV

[PATCH] D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type

erik.pilkington created this revision. A DecompositionDecls' bindings have a null type until the initializer is attached, if the initializer is dependent, then the bindings should be set to have dependent type. For non-foreach bindings, this is done in Sema::CheckCompleteDecompositionDeclaratio