[PATCH] D34146: [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305291: [clangd] Allow to override contents of the file during completion. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34146?vs=102328=102331#toc Repository: rL LLVM

[PATCH] D34146: [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:190 + llvm::Optional OverridenContents) { + std::string DraftStorage; + if (!OverridenContents) { This is the relevant line that changed from the previous

[PATCH] D34146: [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. This is a reapplied r305280 with a fix to the crash found by build bots (StringRef to an out-of-scope local std::string). https://reviews.llvm.org/D34146 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h unittests/clangd/ClangdTests.cpp Index: