[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

teemperor added a comment. ping. Any objections to adding this GCC alias? https://reviews.llvm.org/D34439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

karies added a comment. For the record, here's what GCC does (from https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#C_002b_002b-Dialect-Options which probably has a typo, the second -Wnoexcept is likely meant to be -Wnoexcept-type): "Enabled by -Wabi and -Wc++1z-compat."

Re: [PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

There's plenty of precedent for supporting a name we like for a flag, and also supporting an alias for GCC compatibility (especially for warning flags). On 21 June 2017 at 10:56, Raphael Isemann via Phabricator < revi...@reviews.llvm.org> wrote: > teemperor added a comment. > > @ahatanak I think

[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

teemperor added a comment. @ahatanak I think we can leave the more expressive clang name for this warning and just add the bit cryptic GCC name for compability. But I don't have a strong opinion on this. https://reviews.llvm.org/D34439 ___

Re: [PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

I couldn't find a case where both gcc and clang agreed at the same time that they should emit this warning, but I think that's just bugs in the way we detect these cases. From the near-identical warning message I would say they both should emit warnings for the same cases (and probably will in the

Re: [PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

Does the GCC warning warn on the same cases? On 21 Jun 2017 10:24 am, "Akira Hatanaka via Phabricator" < revi...@reviews.llvm.org> wrote: > ahatanak added a comment. > > I didn't know gcc had its own option. This change seems reasonable to me. > > Since c++1z-compat-mangling was added just a few

[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

ahatanak added a comment. I didn't know gcc had its own option. This change seems reasonable to me. Since c++1z-compat-mangling was added just a few days ago, should we just rename it instead of adding an alias? https://reviews.llvm.org/D34439

[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

teemperor created this revision. GCC has named this `-Wnoexcept-type`, so let's add an alias to stay compatible with the GCC flags. https://reviews.llvm.org/D34439 Files: include/clang/Basic/DiagnosticGroups.td test/SemaCXX/cxx1z-noexcept-function-type.cpp Index: