This revision was automatically updated to reflect the committed changes.
Closed by commit rL306648: Factor out a functionality from
isBeforeInTranslationUnit (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D34506?vs=104358&id=104601#toc
Repository:
rL LLVM
https://re
xazax.hun added a comment.
In https://reviews.llvm.org/D34506#792313, @akyrtzi wrote:
> I'd prefer to avoid including whitespace-only changes (there are a couple of
> lines in the diff with only whitespace change), otherwise LGTM!
Great, thank you! If no one has objections I will commit this t
xazax.hun updated this revision to Diff 104358.
xazax.hun added a comment.
- Removed the whitespace changes
- Factored out one more condition
https://reviews.llvm.org/D34506
Files:
include/clang/Basic/SourceManager.h
lib/Basic/SourceManager.cpp
Index: lib/Basic/SourceManager.cpp
==
akyrtzi added a comment.
I'd prefer to avoid including whitespace-only changes (there are a couple of
lines in the diff with only whitespace change), otherwise LGTM!
https://reviews.llvm.org/D34506
___
cfe-commits mailing list
cfe-commits@lists.llv
xazax.hun added a comment.
I created a new public API that is using a piece of code that was factored out
from `isBeforeInTranslationUnit`. Using this new function it is possible to
implement proper comparison of source locations within the Static Analyzer.
What do you think?
https://reviews.
xazax.hun updated this revision to Diff 104167.
xazax.hun retitled this revision from "Relax an assert in the comparison of
source locations" to "Factor out a functionality from
`isBeforeInTranslationUnit`".
xazax.hun edited the summary of this revision.
xazax.hun added a comment.
- New approach