This revision was automatically updated to reflect the committed changes.
Closed by commit rL306922: [Driver] Check that the iOS deployment target is iOS
10 or earlier if (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D34529?vs=104958=104972#toc
Repository:
rL
bob.wilson accepted this revision.
bob.wilson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ahatanak updated this revision to Diff 104958.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Set Micro to 99 too.
https://reviews.llvm.org/D34529
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Darwin.cpp
test/Driver/darwin-version.c
bob.wilson added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1350
+Minor = 99;
+ }
} else if (Platform == TvOS) {
What about Micro = 99?
https://reviews.llvm.org/D34529
___
ahatanak updated this revision to Diff 104906.
ahatanak added a comment.
Address review comments.
- Change the error message from "invalid iOS deployment version '%0', maximum
allowable version is iOS 10" to "invalid iOS deployment version '%0', iOS 10 is
the maximum deployment target for
bob.wilson added a comment.
The proposed error message does not provide any information about why the
version is invalid. That could be confusing. Your comment in the code is more
clear: "iOS 10 is the maximum deployment target for 32-bit targets". Can you
say something like that in the error
ahatanak created this revision.
The following changes are made to the driver since 32-bit apps do not run on
iOS 11 or later:
- If the deployment target is set explicitly, either with a command-line option
or an environment variable, the driver should report an error if the version is
greater
