[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

2017-06-29 Thread Yan Wang via Phabricator via cfe-commits
yawanng updated this revision to Diff 104689. yawanng added a comment. Pull back the previous change. For some reason it's lost. https://reviews.llvm.org/D34633 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecOpenCheck.cpp clan

[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

2017-06-29 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh requested changes to this revision. chh added a comment. This revision now requires changes to proceed. Please update the subject line and summary. The new diff shows only the renaming of check name and file names. Were the other changes for format and macro lost or are they going to be in ano

[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

2017-06-28 Thread Yan Wang via Phabricator via cfe-commits
yawanng updated this revision to Diff 104574. yawanng added a comment. Herald added subscribers: mgorny, srhines. rename the check. https://reviews.llvm.org/D34633 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecOpenCheck.cpp c

[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

2017-06-26 Thread Yan Wang via Phabricator via cfe-commits
yawanng created this revision. yawanng added a project: clang-tools-extra. Herald added subscribers: xazax.hun, JDevlieghere. Handle a case when the function is passed as an argument of a function-like macro. Plus fix a format that was forgotten to commit last time. Repository: rL LLVM https