[PATCH] D34649: Remove addtional parameters in function std::next() and std::prev()

2017-07-24 Thread Rachel Craik via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308932: Remove addtional parameters in function std::next() and std::prev() (authored by rcraik). Changed prior to commit: https://reviews.llvm.org/D34649?vs=104030&id=107977#toc Repository: rL LLVM

[PATCH] D34649: Remove addtional parameters in function std::next() and std::prev()

2017-07-05 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. > Creating a function pointer with proper parameters pointing to std::next() or > std::prev() should work. Actually, according to the standard taking the address of a STL function is UB, and

[PATCH] D34649: Remove addtional parameters in function std::next() and std::prev()

2017-06-26 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: include/iterator:619 template inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 Might fix the spelling error in "BidirectionalIter" while you're here. https://reviews.llvm.org/D34649 __

[PATCH] D34649: Remove addtional parameters in function std::next() and std::prev()

2017-06-26 Thread Jason Liu via Phabricator via cfe-commits
jasonliu created this revision. Creating a function pointer with proper parameters pointing to std::next() or std::prev() should work. This change moves the invented paramater for enable_if over to the return type to resolve this QoI issue. https://reviews.llvm.org/D34649 Files: include/ite