This revision was automatically updated to reflect the committed changes.
Closed by commit rL307446: [MS] Don't statically initialize dllimport member
function pointers (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D34714?vs=104289=105768#toc
Repository:
rL LLVM
rnk commandeered this revision.
rnk edited reviewers, added: majnemer; removed: rnk.
rnk added a comment.
@majnemer will be back Monday, grabbing this.
https://reviews.llvm.org/D34714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk added a comment.
Have a minute to get to this? My attempt to work around the bug in Chromium was
incomplete.
https://reviews.llvm.org/D34714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
majnemer added a comment.
In https://reviews.llvm.org/D34714#793205, @rnk wrote:
> Did you locally add a test case for the dllimport member function pointer
> template argument?
Arg, yes. Forgot to add the file...
Comment at: lib/Sema/SemaTemplate.cpp:5704
+ else
+NPV
rnk added a comment.
Did you locally add a test case for the dllimport member function pointer
template argument?
Comment at: lib/Sema/SemaTemplate.cpp:5704
+ else
+NPV = isNullPointerValueTemplateArgument(S, Param, ParamType, ResultArg);
+
Think we
majnemer created this revision.
r306137 made dllimport pointers to member functions non-constant. This
is correct because a load must be executed to resolve any dllimported
data. However, r306137 did not account for the use of dllimport member
function pointers used as template arguments.
This
