This revision was automatically updated to reflect the committed changes.
Closed by commit rL336037: Driver: Don't mix system tools with devtoolset
tools on RHEL (authored by tstellar, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D34
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
tstellar updated this revision to Diff 142294.
tstellar added a comment.
Replaced the if (Distro.isRedhat()) check with a string compare on the
GCC installation lib. This narrows the scope of the fix and also makes
it possible to write a test case. The code that detects distros ignores
sysroot a
bruno added a comment.
Is there a way to test this?
Comment at: lib/Driver/ToolChains/Linux.cpp:220
+ "/../bin").str());
+ }
+
You can remove the curly braces here.
https://reviews.llvm.org/D34848
__
tstellar added a comment.
Ping.
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar added a comment.
Ping.
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar added a comment.
Ping.
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar added a comment.
Ping.u1
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar created this revision.
On RHEL, devtoolset provides a more up-to-date toolchain than the base
install, and we want to make sure all the tools use are from the same
toolchain.
https://reviews.llvm.org/D34848
Files:
lib/Driver/ToolChains/Linux.cpp
Index: lib/Driver/ToolChains/Linux.c
