[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

2017-06-30 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added a comment. Awesome, thank you for all the reviews! https://reviews.llvm.org/D34868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

2017-06-30 Thread Adam Nemet via Phabricator via cfe-commits
anemet accepted this revision. anemet added a comment. This revision is now accepted and ready to land. Looks great, thank you! https://reviews.llvm.org/D34868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

2017-06-30 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 104964. modocache marked 4 inline comments as done. modocache added a comment. Address comments, for the most part. As for the documentation: I think this is OK for now, but there are definitely a few more options that I'd like to document, and those will

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

2017-06-30 Thread Adam Nemet via Phabricator via cfe-commits
anemet added a comment. Great! Comment at: docs/UsersManual.rst:330-332 This option, which defaults to off, controls whether Clang prints the profile hotness associated with a diagnostics in the presence of profile-guided optimization information. This is

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

2017-06-30 Thread Brian Gesiak via Phabricator via cfe-commits
modocache created this revision. Herald added a subscriber: fhahn. Depends on https://reviews.llvm.org/D34867. Add a Clang frontend option to enable optimization remark hotness thresholds, which were added to LLVM in https://reviews.llvm.org/D34867. This prevents diagnostics that do not meet a